-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Stage IndexReader #12159
[query] Stage IndexReader #12159
Conversation
The important new stuff is mostly in StagedIndexReader, which translates a subset of the operations on IndexReader.scala. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit, lgtm otherwise
@@ -95,15 +95,11 @@ class StagedIndexReader(emb: EmitMethodBuilder[_], spec: AbstractIndexSpec) { | |||
endQuerySettable.asBaseStruct.loadField(cb, 0).get(cb).asInt64.value - | |||
startQuerySettable.asBaseStruct.loadField(cb, 0).get(cb).asInt64.value | |||
) | |||
cb.assign(startLeaf, cb.memoize(startQuerySettable.asBaseStruct.loadField(cb, 1))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the memoize call needed, aren't we assigning it to a variable anyways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
look at that deleted code! Good riddance.